zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Nixon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused
Date Mon, 20 May 2019 23:07:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844371#comment-16844371
] 

Brian Nixon commented on ZOOKEEPER-3349:
----------------------------------------

This parameter is being used again as of ZOOKEEPER-3378. Nothing to do here.

> QuorumCnxManager socketTimeout unused
> -------------------------------------
>
>                 Key: ZOOKEEPER-3349
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3349
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: quorum
>    Affects Versions: 3.6.0
>            Reporter: Brian Nixon
>            Priority: Trivial
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> QuorumCnxManager member variable 'socketTimeout' is not used anywhere in the class. It's
clear from the context that it should either be removed entirely or invoked in QuorumCnxManager::setSockOpts.
Since the QuorumPeer syncLimit can be changed by jmx, I'm thinking that the former is the
better solution.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message