zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Norbert Kalmar <nkal...@cloudera.com.INVALID>
Subject Re: [DISCUSS] Should we move contrib and recipes into separate repos?
Date Thu, 23 May 2019 09:52:21 GMT
I agree with Enrico on dropping contrib and keeping recipes.
My reasons for dropping contrib projects:
- There is not much, if anything, going on around contrib. Even before
maven migration, it was a mess (it was duplicated in the tarball, some were
built, some were not, kind of randomly). Take for example loggraph. I'm not
even sure it works with current ZK. But if anyone would ask me, I would
just recommend  Logformatter and Snapshotformatter. And I could argue
against all components, of course, I don't know who uses it and for what.

- Contrib projects wouldn't be "lost", and if someone reasons for a
component, we could keep that. Or update the docs and recommend something
else for the use-case. But at least we would clean up the contrib
directory, I'm pretty sure most of the components are not used, or
something else can be recommended.

- It still tends to be forgotten. Unless tests fails, nobody really pays
attention if its in sync or not.

Regards,
Norbert

On Wed, May 22, 2019 at 10:25 PM Ted Dunning <ted.dunning@gmail.com> wrote:

> I think that the key question is whether independent releases make sense.
>
> If you have two things that must always be released in synchrony, then
> having them in the same repo is a good idea.
>
> If you have two things that are released completely independently, then
> separate repos make sense.
>
>
> On Wed, May 22, 2019 at 10:22 AM Enrico Olivelli <eolivelli@gmail.com>
> wrote:
>
> > Il mer 22 mag 2019, 09:59 Tamas Penzes <tamaas@cloudera.com.invalid> ha
> > scritto:
> >
> > > Hi All,
> > >
> > > There is trend among Apache projects to minimise the content of the
> main
> > > project and move not crucial parts into separate repos. I mostly prefer
> > the
> > > mono-repo style development, but in some cases where the connection
> > between
> > > the main project and a subproject is weak I find this idea supportable.
> > >
> > > We have discussed it earlier that it might be a good idea to move the
> > > zookeeper-contrib and zookeeper-recipes into separate repositories
> still
> > > maintained by the ZooKeeper team, but I would be curious about your
> > > opinion.
> > >
> > > Do you find this idea useful?
> > > What do you think, what would be the pros and cons for such separation?
> > >
> >
> > I guess that if we separate those modules they will soon be out of sync
> > with the latest master.
> > We won't ever 'release' them and/or try to compile againts latest
> zookeeper
> > version.
> >
> > I feel 'recipes' should stay in the repo as they are like a reference
> live
> > guide about using zookeeper.
> >
> > Are 'contrib' modules in use?
> >
> > If the answer is 'no' we should drop them.
> > Current versions will stay on git forever but we won't maintain them
> > anymore
> >
> >
> > Enrico
> >
> >
> >
> > > Thanks, Tamaas
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message