zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli opened a new pull request #955: ZOOKEEPER-3362: Create a simple checkstyle file
Date Tue, 21 May 2019 14:58:22 GMT
eolivelli opened a new pull request #955: ZOOKEEPER-3362: Create a simple checkstyle file
URL: https://github.com/apache/zookeeper/pull/955
 
 
   Create a basic checkstyle file, in order to cover the minimal check on author tags.
   
   This is needed in order to drop old ANT based precommit job (see ZOOKEEPER-3351)
   
   We will not remove legacy checkstyle configuration file in zookeeper-server/src/test/resources/checkstyle.xml
because it is referred by ANT build.xml files (even if we are not actually using that target).
   
   This task won't add a complete checkstyle configuration with usual checks because it would
imply almost a change at every .java in the codebase.
   
   Author: Enrico Olivelli <eolivelli@apache.org>
   
   Reviewers: andor@apache.org
   
   Closes #909 from eolivelli/fix/checkstyle and squashes the following commits:
   
   fdda1571c [Enrico Olivelli] use a property in order to define checkstyle version
   92192981f [Enrico Olivelli] Skip CPP tests when using -DskipTests
   b816e563e [Enrico Olivelli] Add cppunit for Travis
   faf37bb37 [Enrico Olivelli] ZOOKEEPER-3362 Create a simple checkstyle file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message