zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server
Date Fri, 17 May 2019 11:45:50 GMT
eolivelli commented on a change in pull request #923: ZOOKEEPER-1426: add version command to
the zookeeper server
URL: https://github.com/apache/zookeeper/pull/923#discussion_r285089642
 
 

 ##########
 File path: zookeeper-server/src/test/resources/test-scripts.sh
 ##########
 @@ -217,6 +217,9 @@ stop
 
 $ZKSI --force --myid=1 --configfile "$ZOOCFGDIR/$ZOOCFG" || fail $LINENO
 
+#test version script
 
 Review comment:
   is this file working on maven build ? 
   It checks for "ls build/zookeeper*.jar" but the mavenized build does not create such file.
   
   If I am not wrong, do you mind @szepet fixing it up ? otherwise as soon as we drop the
ant-based build this script will need a fix.
   Honestly I didn't known such file existed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message