zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
Date Thu, 16 May 2019 11:13:17 GMT
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required
packages in OSGi (needed for curator)
URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493025000
 
 
   I've sent email to zookeeper-dev mailing list:
   
   > ZooKeeper and OSGi (maven)
   
   Hi,
   
   I 've created issue [1] with missing exported packages in osgi for zookeeper 3.4.10. Then
I started to prepare maven OSGi packaging [2] for the higher version of ZooKeeper (in the
PR for issue).
   
   I've tried to implement OSGi packaging with the low impact. So I've tried to create OSGi
bundles from Zookeeper-server and from zookeeper-jute modules.
   
   But there is a problem for this solution:
   
       zookeeper-jute has package 'org.apache.zookeeper.data', it has to be exported for zookeeper-server
to use it
       zookeeper-server contains also package 'org.apache.zookeeper.data', which has to be
exported, because it is used from packages like org.apache.zookeeper, which are exported
   
   -> bundles can not be deployed into osgi as two libraries are exporting the same packages
   
   
   Solution:
   
       best solution is to change name of one of these packages (probably in module zookeeper-jute
- which us used only by zookeeper) - but question is, whether this change is feasible
       only other solution is to create only one bundle (e.g. zookeeper-osgi), which will
contain both libraries together and will expose their both packages at the same time (similar
approach is used in e.g. hibernate-osgi, httpcore-osgi, httpclient-osgi)
   
   Solution #1 is a better solution, I would like to ask for your opinion about feasibility
of renaming zookeeper-jute generated packages to not collide with zookeeper-server. 
   (As these packages are to be used only for zookeeper, it shouldn't cause any harm)
   
   If #1 is not acceptable, then we can go with #2. But I highly suggest to consider renaming
of zookeeper-jute's packages in the nearest point in the future as possible and return to
solution #1.
   
   Best regards,
   
   jiri
   
   
   [1] https://issues.apache.org/jira/browse/ZOOKEEPER-3389
   [2] https://github.com/apache/zookeeper/pull/945
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message