zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
Date Wed, 15 May 2019 14:14:12 GMT
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required
packages in OSGi (needed for curator)
URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492672683
 
 
   @nkalmar @eolivelli
   I'm getting close to the finishing. I just want to clarify some facts and also ask for
the help.
   - just to be sure, only zookeeper-server jar will be compiled as OSGi bundle? (I see also
possible modules jute and recipes, so I would like to be sure)
   - I'm currently facing a problem with OSGi build, there is a warning that zookeeper-server
is exporting package, which is also present in different jar - zookeeper-jute. (Packages org/apache/zookeeper/server/quorum
and org/apache/zookeeper/server/persistence)
   It would help me to know, how these packages should be handled. I looked into package 'quorum'
and it seems, that it contains different classes. But  even if they are different, it could
change in the FUTURE. So I'd like to ask, how to face it
      - best solution from OSGi would be to change jute to use different package names - but
it is probably not possible 
      - best way (from my POV) is to merge packages together (with rule that classes from
zookeeper-server has to be treated as primary) - but it can remove some classes which are
needed to run and I have also problems to define it with maven-plugin (still not sure why
it is not working, I think it should work)
      - may be it is possible also to ignore these packages from zookeeper-jute - but it doesn't
seem much probable
   What do you think about it? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message