zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on issue #940: ZOOKEEPER-3386: Add admin command to display voting view
Date Mon, 13 May 2019 06:47:46 GMT
eolivelli commented on issue #940: ZOOKEEPER-3386: Add admin command to display voting view
URL: https://github.com/apache/zookeeper/pull/940#issuecomment-491696727
 
 
   @enixon sorry I was not clear.
   I am not taking about jmx (I also think it ia going to disappear some day)
   
   I am saying that we are going to serialize to json some internal data structure which be
changed in the future and consumers of the API won't be able to understand the response.
   The final result also depends on the JSON marshaller, this may change in the future and
we could break this new API without notice.
   
   Honestly I don't know how much the admin endpoint is to be considered an API.
   
   We should state it somewhere in docs.
   
   Anyway my proposal is to create a specific java class which modes the response (mostly
a wrapper around the voting view), this way any refactor to the internals will show up in
the admin endpoint code and we will see that we are changing the response we are serving to
monitoring tools

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message