zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider
Date Fri, 10 May 2019 19:07:03 GMT
eolivelli commented on a change in pull request #918: ZOOKEEPER-3366: Pluggable metrics system
for ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#discussion_r283008790
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/metrics/impl/DefaultMetricsProvider.java
 ##########
 @@ -94,9 +99,13 @@ public Counter getCounter(String name) {
         }
 
         @Override
-        public boolean registerGauge(String name, Gauge gauge) {
-            // Not supported
-            return false;
+        public void registerGauge(String name, Gauge gauge) {
+            if (gauge == null) {
+                // null means 'unregister'
 
 Review comment:
   make sense. I will change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message