zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] anmolnar commented on issue #922: ZOOKEEPER-3361: Add multi version of getChildren request
Date Fri, 10 May 2019 14:54:48 GMT
anmolnar commented on issue #922: ZOOKEEPER-3361: Add multi version of getChildren request
URL: https://github.com/apache/zookeeper/pull/922#issuecomment-491318244
 
 
   I agree with implementing `getChildren()` within multi is wasting quorum vote time. It
also has a disadvantage that it's using different code path from standard getChildren API,
so we probably could nail down that the original approach was bad and misleading.
   
   @szepet I think you can close to other PR to avoid further confusion.
   
   However I think the implementation of a separate API call for `getChildren()` is acceptable
in this PR. @lvfangmin Do you have any objection against committing this patch as it is?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message