zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file
Date Wed, 08 May 2019 15:40:17 GMT
eolivelli commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file
URL: https://github.com/apache/zookeeper/pull/909#issuecomment-490538183
 
 
   @anmolnar thank you for checking this patch
   
   > @eolivelli Why isn't the new checkstyle file not the same as the ant version?
   This new file is very simple and it mostly checks only for "author" javadoc tags it is
the same check we are doing in the precommit ANT based build.
   
   Current "checkstyle" file is not really used and we would have thousands of failures.
   It will be an hard work to make the code base compliant with such file (I can help doing
it but it will take weeks and many patches)
   
   So my approach is to:
   - introduce a new checkstyle file (it will grow in the future)
   - do what is needed to be able to drop the ANT based precommit script
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message