zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] lvfangmin commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK
Date Wed, 08 May 2019 05:03:08 GMT
lvfangmin commented on a change in pull request #919: ZOOKEEPER-3356: Implement advanced Netty
flow control based on feedback from ZK
URL: https://github.com/apache/zookeeper/pull/919#discussion_r281913876
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/NettyServerCnxnTest.java
 ##########
 @@ -184,4 +191,135 @@ public void run() {
             assertArrayEquals("unexpected data", "test".getBytes(StandardCharsets.UTF_8),
contents);
         }
     }
+
+    @Test
+    public void testEnableDisableThrottling_secure_random() throws Exception {
 
 Review comment:
   Yes, you mentioned that in a separate PR before :)
   
   Parameterized test will run the combination for every tests in the class, which makes sense
if it's a class wide test which is for testing classes implementing the same interface. Here
it's just a test combination for the specific test scenario with enable/disable throttling,
so that's why I think using a help method is better. Let me know if this makes sense or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message