zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality
Date Tue, 07 May 2019 20:29:04 GMT
eolivelli commented on a change in pull request #910: ZOOKEEPER-3364 Compile with strict options
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910#discussion_r281816856
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/metrics/impl/MetricsProviderBootstrap.java
 ##########
 @@ -34,11 +35,12 @@ public static MetricsProvider startMetricsProvider(String metricsProviderClassNa
             throws MetricsProviderLifeCycleException {
         try {
             MetricsProvider metricsProvider = (MetricsProvider) Class.forName(metricsProviderClassName,
-                    true, Thread.currentThread().getContextClassLoader()).newInstance();
+                    true, Thread.currentThread().getContextClassLoader()).getConstructor().newInstance();
 
 Review comment:
   this is deprecated on JDK10+ and the build fails on Travis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message