zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality
Date Tue, 07 May 2019 15:05:21 GMT
eolivelli commented on a change in pull request #910: ZOOKEEPER-3364 Compile with strict options
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910#discussion_r281677737
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/auth/MiniKdc.java
 ##########
 @@ -103,7 +103,7 @@ public static void main(String[] args) throws Exception {
         Properties userConf = new Properties();
         InputStreamReader r = null;
         try {
-            r = new InputStreamReader(new FileInputStream(file), Charsets.UTF_8);
+            r = new InputStreamReader(new FileInputStream(file), StandardCharsets.UTF_8);
 
 Review comment:
   @anmolnar 
   it is because org.apache.commons.io.Charsets.UTF_8 is deprecated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message