zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration
Date Thu, 02 May 2019 11:12:58 GMT
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration
URL: https://github.com/apache/zookeeper/pull/927#discussion_r280374268
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -1383,4 +1392,85 @@ public void setResponseCachingEnabled(boolean isEnabled) {
     public ResponseCache getReadResponseCache() {
         return isResponseCachingEnabled ? readResponseCache : null;
     }
+
+    protected void registerMetrics() {
+        MetricsContext rootContext = ServerMetrics
+                .getMetrics()
+                .getMetricsProvider()
+                .getRootContext();
+
+        final ZKDatabase zkdb = this.getZKDatabase();
+        final ServerStats stats = this.serverStats();
+
+        rootContext.registerGauge("avg_latency", stats::getAvgLatency);
+
+        rootContext.registerGauge("max_latency", stats::getMaxLatency);
+        rootContext.registerGauge("min_latency", stats::getMinLatency);
+
+        rootContext.registerGauge("packets_received", stats::getPacketsReceived);
 
 Review comment:
   It's not meant to come up with direct instrumentation, as you know the type (counter here).
You'd have to write a custom collector, which is what you'd be doing if you were producing
the output based on your existing instrumentation system.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message