From dev-return-80192-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Sun Apr 14 03:01:02 2019
Return-Path: <dev-return-80192-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 695EE180668
	for <archive-asf-public@cust-asf.ponee.io>; Sun, 14 Apr 2019 05:01:02 +0200 (CEST)
Received: (qmail 22873 invoked by uid 500); 14 Apr 2019 03:01:00 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 22862 invoked by uid 99); 14 Apr 2019 03:01:00 -0000
Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Apr 2019 03:01:00 +0000
Received: from jira-lw-us.apache.org (unknown [207.244.88.139])
	by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4585BE02FD
	for <dev@zookeeper.apache.org>; Sun, 14 Apr 2019 03:01:00 +0000 (UTC)
Received: from jira-lw-us.apache.org (localhost [127.0.0.1])
	by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 05E5C24595
	for <dev@zookeeper.apache.org>; Sun, 14 Apr 2019 03:01:00 +0000 (UTC)
Date: Sun, 14 Apr 2019 03:01:00 +0000 (UTC)
From: "David Mollitor (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13227908.1555210840000.67849.1555210860020@Atlassian.JIRA>
In-Reply-To: <JIRA.13227908.1555210840000@Atlassian.JIRA>
References: <JIRA.13227908.1555210840000@Atlassian.JIRA> <JIRA.13227908.1555210840320@jira-lw-us.apache.org>
Subject: [jira] [Created] (ZOOKEEPER-3365) Use New Concurrent HashMap in
 NettyServerCnxnFactory
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

David Mollitor created ZOOKEEPER-3365:
-----------------------------------------

             Summary: Use New Concurrent HashMap in NettyServerCnxnFactory 
                 Key: ZOOKEEPER-3365
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3365
             Project: ZooKeeper
          Issue Type: Improvement
          Components: server
    Affects Versions: 3.6.0
            Reporter: David Mollitor
            Assignee: David Mollitor
             Fix For: 3.6.0


{code:java|title=NettyServerCnxnFactory.java}
    // Access to ipMap or to any Set contained in the map needs to be
    // protected with synchronized (ipMap) { ... }
    private final Map<InetAddress, Set<NettyServerCnxn>> ipMap = new HashMap<>();

    private void addCnxn(NettyServerCnxn cnxn) {
        cnxns.add(cnxn);
        synchronized (ipMap){
            InetAddress addr =
                ((InetSocketAddress)cnxn.getChannel().remoteAddress()).getAddress();
            Set<NettyServerCnxn> s = ipMap.get(addr);
            if (s == null) {
                s = new HashSet<>();
                ipMap.put(addr, s);
            }
            s.add(cnxn);
        }
    }
{code}

This can be done better (less code, less contention) with Java 8 Map API.  Although, as I look at this, the only thing this is used for is a count of the number of connections from each address.  Maybe this should just store a count instead of a collection.

https://github.com/apache/zookeeper/blob/f69ad1b0fed88da3c1b67fd73031e7248c0564f7/zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)