From dev-return-80004-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Apr 9 13:40:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D4BCF180629 for ; Tue, 9 Apr 2019 15:40:01 +0200 (CEST) Received: (qmail 77292 invoked by uid 500); 9 Apr 2019 13:20:23 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 77281 invoked by uid 99); 9 Apr 2019 13:20:23 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Apr 2019 13:20:23 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5F8F9E06F1 for ; Tue, 9 Apr 2019 13:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2041B24599 for ; Tue, 9 Apr 2019 13:40:00 +0000 (UTC) Date: Tue, 9 Apr 2019 13:40:00 +0000 (UTC) From: "Andor Molnar (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (ZOOKEEPER-3341) Remove Superfluous ByteBuffer Duplicate MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-3341: --------------------------------------- Assignee: David Mollitor > Remove Superfluous ByteBuffer Duplicate > --------------------------------------- > > Key: ZOOKEEPER-3341 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3341 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0, 3.5.6 > > Time Spent: 1h > Remaining Estimate: 0h > > {code:java|title=QuorumCnxManager.java} > byte[] msgArray = new byte[length]; > din.readFully(msgArray, 0, length); > ByteBuffer message = ByteBuffer.wrap(msgArray); > addToRecvQueue(new Message(message.duplicate(), sid)); > {code} > The {{message}} is being duplicated and the original is GC'ed. Just pass the {{message}}; do not bother with making a duplicate. I think this is a copy+paste bug. > https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1195-L1198 -- This message was sent by Atlassian JIRA (v7.6.3#76005)