From dev-return-80577-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Apr 29 22:51:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 54DA418061A for ; Tue, 30 Apr 2019 00:51:03 +0200 (CEST) Received: (qmail 59765 invoked by uid 500); 29 Apr 2019 22:51:02 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 59713 invoked by uid 99); 29 Apr 2019 22:51:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Apr 2019 22:51:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 93779E256F for ; Mon, 29 Apr 2019 22:51:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6C9C62581E for ; Mon, 29 Apr 2019 22:51:00 +0000 (UTC) Date: Mon, 29 Apr 2019 22:51:00 +0000 (UTC) From: "Hudson (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3306) Node may not accessible due the the inconsistent ACL reference map after SNAP sync MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3306?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16829798#comment-16829798 ]=20 Hudson commented on ZOOKEEPER-3306: ----------------------------------- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #334 (Se= e [https://builds.apache.org/job/Zookeeper-trunk-single-thread/334/]) ZOOKEEPER-3306: Fixing node not accessible issue due the inconsistent (ando= r: rev 46b2018dbe008e010462e0dc06ddb73981d19d2a) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/persist= ence/FileTxnSnapLogTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTre= e.java > Node may not accessible due the the inconsistent ACL reference map after = SNAP sync=20 > -------------------------------------------------------------------------= ---------- > > Key: ZOOKEEPER-3306 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3306 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.4, 3.6.0, 3.4.13 > Reporter: Fangmin Lv > Assignee: Fangmin Lv > Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > This is a new bug we found on production. > ZooKeeper uses ACL reference id and count to save the space in snapshot. = During fuzzy snapshot sync, the reference count may not be updated correctl= y in case like the znode is already exist. > When ACL reference count reaches 0, it will be deleted from the system, b= ut actually there might be other nodes still using it. And when visiting a = node with the deleted ACL id, it will be rejected because it doesn't exist = anymore. > Here is the detailed flow for one of the scenario here: > # Server A starts to have snap sync with=C2=A0leader > # After serializing the ACL map to Server A, there is a txn T1 to create= a node=C2=A0N1 with new ACL_1 which was not exist in ACL map > # On leader, after this txn, the ACL map will be ID1 -> (ACL_1, COUNT: 1= ), and data tree N1 -> ID1 > # On server A, it will be empty ACL map, and N1 -> ID1 in fuzzy snapshot > # When replaying the txn T1, it will skip at the beginning since the nod= e is already exist, which leaves an empty ACL map,=C2=A0and N1 is referenci= ng to a non-exist ACL ID1 > # Node N1 will be not accessible because the ACL not exist, and if it be= came leader later then all the write requests will be rejected as well with= marshalling error. > We're still working on the fix,=C2=A0suggestions are welcome. -- This message was sent by Atlassian JIRA (v7.6.3#76005)