From dev-return-80516-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sat Apr 27 22:08:49 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5F19D180630 for ; Sun, 28 Apr 2019 00:08:49 +0200 (CEST) Received: (qmail 85023 invoked by uid 500); 27 Apr 2019 22:08:48 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 85005 invoked by uid 99); 27 Apr 2019 22:08:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Apr 2019 22:08:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 23A4CC00D4 for ; Sat, 27 Apr 2019 22:08:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.201 X-Spam-Level: X-Spam-Status: No, score=-0.201 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id zOzfzxuK78hn for ; Sat, 27 Apr 2019 22:08:45 +0000 (UTC) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BFC6D5F24A for ; Sat, 27 Apr 2019 21:59:28 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id e18so121426lja.5 for ; Sat, 27 Apr 2019 14:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=jAXHv13bjtRDBnxGFzFAFCMEhGCp7RZHlcu+E4xwTqE=; b=mA0LnqV9Z+vY1FNC/bjb1s/keUL9BC6Btt2GcROT/eK7+eiCJXHAxyKRZTAmZ1tVhf NRS3/uUuW1aaX30USWty1Vn8x0o/yuQkM0FmUgZCoNriAjtbP+FyTHAxLTc5PN8b5h5s NkG0uxY9pje0ytBiPwzzliu3TBW8PQiUTF/UrwkUK1BxGISADYayyEURd+4GGhYBoySv IdL9NSKT37uBa9+3UcGlfUG01jmbZEKdSZC7NVlqW4UDyI1PdzI7+FhT7xQqMHAxzvhY Mfq6qEybsXfsKoqPkC7Uc8+JsxEI1Zi7M52l5DYr7k1uYTAx6qFuVyLqHGahwsVgWiV/ aVOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=jAXHv13bjtRDBnxGFzFAFCMEhGCp7RZHlcu+E4xwTqE=; b=X3DFQWQ9KmaEYDDyy6YlvEDN9vxMXsO2dF4sY49qx6GKvkeF9mIdjlrimD2QC1Vi/2 z/6Z5DptThJCcU2K5XwC4gE71udW2+txYn03Adu3KT/m9sK4fNxJ0yE+2B/iohZ6jfFz 3k/XVHruV3/qSXqVdptZEonVkT6a+q2MTNFQ7pl6wrOOrNkd2iwsuhPqmE0PAdj34xf6 0fNeNMArunXPSTRFSNegWugA54GoA0KushC70Sxacu6xliHg6BDg1yCdf0NY2nwrDpQ1 mLtSv97PPmrrTjNtYLET/xVIhPOajH3QXA7z4P0W8yeahEMF0hc68BV7nAAKMMdAgQ6z dhrw== X-Gm-Message-State: APjAAAVCDQDnXoKB9ef3PCNf3yWEYuuEJjEuYnQpGjhiGZr4d/ORW9+E uGxET0T9P/b4/bQjOcrHtqgpZUZXTV8KHaa9LZoEaJA593s= X-Google-Smtp-Source: APXvYqzBLD6yB/WYw/m8WebCIlQ5kb2etzG8CJ4Xv+xg5uJ09KR43YUAzpQ07/udztQret0fKp3M4b2Ozw3uKllNe9o= X-Received: by 2002:a2e:9c0c:: with SMTP id s12mr3666074lji.106.1556402367231; Sat, 27 Apr 2019 14:59:27 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Enrico Olivelli Date: Sat, 27 Apr 2019 23:59:15 +0200 Message-ID: Subject: Re: Maven dependencies for client in ZK 3.5.5 rc5 - clean up needed ? To: DevZooKeeper Content-Type: text/plain; charset="UTF-8" Norbert (and Andor) This is my patch for master, it must be adapted to 3.5 branch as we have a few more dependencies on 3.6 (snappy, dropwizard...) https://github.com/apache/zookeeper/pull/925 It includes a global fix up of poms, because as "zookeeper" pom imported junit, every other submodule that was using it didn't have to explicitly declare the dependency. See the other comments on the patch for the details. I think it is worth to commit it to master and fix 3.5.5 as well, now that we are doing our first Mavenized release Enrico Il giorno sab 27 apr 2019 alle ore 20:27 Enrico Olivelli ha scritto: > > > > Il sab 27 apr 2019, 19:52 Norbert Kalmar ha scritto: >> >> It would be a nice thing to cleanup for sure. >> >> As we also have some test issues on another thread, I think theres a >> possibility for RC6? Anyway, if you can, definitely do the patch Enrico, it >> would be much appreciated! Even if there won't be a new RC, 3.5.6 will have >> it! > > > I think it is worth to try. > I will send a patch soon > > Enrico > >> >> Regards, >> Norbert >> >> On Sat, Apr 27, 2019 at 1:33 PM Enrico Olivelli wrote: >> >> > Hi folks, >> > I am comparing the transitive dependencies that we will import to Java >> > clients with 3.5.5rc5 >> > >> > This is a dependency:tree of a simple application which imports >> > zookeeper-server:3.5.5 >> > >> > com.mycompany:ciaoZk:jar:1.0-SNAPSHOT >> > \- org.apache.zookeeper:zookeeper:jar:3.5.5:compile >> > +- org.apache.zookeeper:zookeeper-jute:jar:3.5.5:compile >> > +- commons-cli:commons-cli:jar:1.2:compile >> > +- org.apache.yetus:audience-annotations:jar:0.5.0:compile >> > +- io.netty:netty-all:jar:4.1.29.Final:compile >> > +- org.slf4j:slf4j-api:jar:1.7.25:compile >> > +- org.slf4j:slf4j-log4j12:jar:1.7.25:compile >> > +- org.eclipse.jetty:jetty-server:jar:9.4.15.v20190215:compile >> > | +- javax.servlet:javax.servlet-api:jar:3.1.0:compile >> > | +- org.eclipse.jetty:jetty-http:jar:9.4.15.v20190215:compile >> > | | \- org.eclipse.jetty:jetty-util:jar:9.4.15.v20190215:compile >> > | \- org.eclipse.jetty:jetty-io:jar:9.4.15.v20190215:compile >> > +- org.eclipse.jetty:jetty-servlet:jar:9.4.15.v20190215:compile >> > | \- org.eclipse.jetty:jetty-security:jar:9.4.15.v20190215:compile >> > +- com.fasterxml.jackson.core:jackson-databind:jar:2.9.8:compile >> > | +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.0:compile >> > | \- com.fasterxml.jackson.core:jackson-core:jar:2.9.8:compile >> > +- com.googlecode.json-simple:json-simple:jar:1.1.1:compile >> > | \- junit:junit:jar:4.10:compile >> > | \- org.hamcrest:hamcrest-core:jar:1.1:compile >> > +- jline:jline:jar:2.11:compile >> > \- log4j:log4j:jar:1.2.17:compile >> > >> > >> > and this one is for 3.5.4-beta >> > >> > com.mycompany:ciaoZk:jar:1.0-SNAPSHOT >> > \- org.apache.zookeeper:zookeeper:jar:3.5.4-beta:compile >> > +- org.slf4j:slf4j-api:jar:1.7.25:compile >> > +- org.slf4j:slf4j-log4j12:jar:1.7.25:compile >> > +- commons-cli:commons-cli:jar:1.2:compile >> > +- log4j:log4j:jar:1.2.17:compile >> > +- org.apache.yetus:audience-annotations:jar:0.5.0:compile >> > \- io.netty:netty:jar:3.10.6.Final:compile >> > >> > I am fine with importing more jetty stuff, and even jackson mapper >> > (but if we can drop them it would be better) >> > But I this that we should at least not have: >> > - junit >> > - hamcrest >> > >> > I feel this is kind of blocker for the release >> > >> > (for 3.6.0 I am working to a zookeeper client BOM which has only >> > client-side needed dependencies, but this is a different story) >> > >> > I can send a patch to fix 3.5.x >> > >> > Enrico >> >