From dev-return-80579-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Apr 30 10:35:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CC37B180651 for ; Tue, 30 Apr 2019 12:35:05 +0200 (CEST) Received: (qmail 61678 invoked by uid 500); 30 Apr 2019 10:35:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 61662 invoked by uid 99); 30 Apr 2019 10:35:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Apr 2019 10:35:04 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] anmolnar commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed Message-ID: <155662049952.9502.10685303133911600444.gitbox@gitbox.apache.org> Date: Tue, 30 Apr 2019 10:34:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anmolnar commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-487903745 @TisonKun Interesting topic. After spending some hours looking into the code I think you might not be able to implement this in a backward compatible-way. Maybe we need a more senior developer to advise on this, but as far as I can see there's no length information in multi response, so there's no way to decide whether the path info needs to be extracted from the `InputArchive` or not. I've reviewed ZOOKEEPER-102 patch as an example of doing schema change in backward compatible way and it looks like `LearnerHandler` manually deserialises the `LearnerInfo` packet. It checks for the size of QuorumPacket and based on that information it can decide what's included in the packet. Not sure if we can do something similar here. Maybe you're facing a limitation of Jute and a reason to migrate from it. :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services