From dev-return-80328-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Apr 19 15:52:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 246E0180627 for ; Fri, 19 Apr 2019 17:52:40 +0200 (CEST) Received: (qmail 28451 invoked by uid 500); 19 Apr 2019 15:52:39 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 28440 invoked by uid 99); 19 Apr 2019 15:52:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Apr 2019 15:52:39 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] lvfangmin commented on issue #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java Message-ID: <155568915928.25548.13824564847102838685.gitbox@gitbox.apache.org> Date: Fri, 19 Apr 2019 15:52:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lvfangmin commented on issue #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java URL: https://github.com/apache/zookeeper/pull/880#issuecomment-484939032 @BELUGABEHR thanks for the detailed info about why we make this change, this is very useful for future reference as well, do you mind to make the title more explicit and maybe including those into Jira summary as well. Since this work is mainly to solving the lock model, do you think the existing test is good enough to cover the concurrency and correctness? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services