zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Enrico Olivelli <eolive...@gmail.com>
Subject Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3
Date Fri, 12 Apr 2019 14:47:54 GMT
Il giorno ven 12 apr 2019 alle ore 15:02 Andor Molnar
<andor@apache.org> ha scritto:
>
> Hi Enrico / Norbert,
>
> -1
>
> During my testing I’ve realised that Maven checksum plugin doesn’t add the filename
to sha512 checksum files. It only contains the hash. As a consequence one is no longer able
to verify the checksum, because ’shasum’ doesn’t recognise the contents.
>
> Please configure the plugin to include the filename.


This will be very useful so +1 for adding it,
IIRC we have the same problem inside the zk binaries inside the 3.4.x
tar ball so I didn't consider it as blocker, I was able to verify
checksums.

Enrico

>
> Thanks,
> Andor
>
>
>
>
> > On 2019. Apr 12., at 13:11, Enrico Olivelli <eolivelli@gmail.com <mailto:eolivelli@gmail.com>>
wrote:
> >
> > (just to be clear)
> >
> > +1 (non binding)
> > checked signatures, checksums
> > built with Maven, run tests on Java 8 on Linux 64bit Fedora 28
> >
> > Configuration of Maven plugins for Rat and Spotbugs fails, but this is
> > not a blocker for the release
> >
> > Super great work Andor !
> >
> > Enrico
> >
> >
> > Il giorno ven 12 apr 2019 alle ore 11:12 Andor Molnar
> > <andor@apache.org <mailto:andor@apache.org>> ha scritto:
> >>
> >> Hi team,
> >>
> >> Just to wrap up the votes so far:
> >>
> >> We got +1 from
> >> - Enrico
> >> - Norbert
> >> Do we have +1 from Maoling by any chance?
> >>
> >> ZooKeeper PMCs,
> >> We need you one more time here to release stable 3.5!
> >>
> >> Please vote!
> >>
> >>
> >> Thanks,
> >> Andor
> >>
> >>
> >>
> >>
> >>
> >>> On 2019. Apr 9., at 21:13, Andor Molnár <andor@apache.org <mailto:andor@apache.org>
<mailto:andor@apache.org <mailto:andor@apache.org>>> wrote:
> >>>
> >>> Thanks Enrico for testing.
> >>>
> >>> I think both checks are valid and should be added to the release verification
procedure. None of the issues are showstopper for the RC, but let's fix them to get a clean
sheet.
> >>>
> >>> - Spotbugs issue can be ignored - null-check is valid when the version has
qualifier: e.g. -SNAPSHOT, which is not the case for releases.
> >>>
> >>> - Rat check has found 27 files with missing license headers for me (attached).
Let's add them to the exclusion list.
> >>>
> >>>
> >>>
> >>> Regards,
> >>>
> >>> Andor
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> On 4/9/19 16:49, Enrico Olivelli wrote:
> >>>> I am testing this RC, before casting my vote I would like to share
> >>>> these problems, I am not sure they are blockers:
> >>>>
> >>>> 1) spotbugs is not passing (tested both with jdk11 and jdk8)
> >>>>
> >>>> mvn clean install -DskipTests spotbugs:check
> >>>>
> >>>> [INFO] --- spotbugs-maven-plugin:3.1.9:check (default-cli) @ zookeeper
---
> >>>> [INFO] BugInstance size is 1
> >>>> [INFO] Error size is 0
> >>>> [INFO] Total bugs: 1
> >>>> [ERROR] Redundant nullcheck of
> >>>> org.apache.zookeeper.version.Info.QUALIFIER which is known to be null
> >>>> in org.apache.zookeeper.Version.getVersion()
> >>>> [org.apache.zookeeper.Version] Redundant null check at
> >>>> Version.java:[line 44] RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE
> >>>> [INFO]
> >>>>
> >>>> 2) Apache RAT check is not passing
> >>>> mvn clean apache-rat:check
> >>>>
> >>>> Those checks need to be added to the release procedure and in CI
> >>>> checks (I have filed an issue yesterday to improve CI checks
> >>>> https://issues.apache.org/jira/browse/ZOOKEEPER-3351 <https://issues.apache.org/jira/browse/ZOOKEEPER-3351>
<https://issues.apache.org/jira/browse/ZOOKEEPER-3351 <https://issues.apache.org/jira/browse/ZOOKEEPER-3351>>)
> >>>>
> >>>>
> >>>> Enrico
> >>>>
> >>>> Il giorno mar 9 apr 2019 alle ore 11:01 Andor Molnar
> >>>> <andor@apache.org <mailto:andor@apache.org>> <mailto:andor@apache.org
<mailto:andor@apache.org>> ha scritto:
> >>>>> This is the first stable release of 3.5 branch: 3.5.5. It resolves
117 issues, including Maven migration, Quorum TLS, TTL nodes and lots of other performance
and stability improvements.
> >>>>>
> >>>>> The full release notes is available at:
> >>>>>
> >>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12343268
<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12343268><https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12343268
<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12343268>>
> >>>>>
> >>>>> *** Please download, test and vote by April 16th 2019, 23:59 UTC+0.
***
> >>>>>
> >>>>> Source files:
> >>>>> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc3/
<https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc3/><https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc3/
<https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc3/>>
> >>>>>
> >>>>> Maven staging repos:
> >>>>> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/
<https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/><https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/
<https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/>>
> >>>>> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/
<https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/><https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/
<https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/>>
> >>>>> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/
<https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/><https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/
<https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/>>
> >>>>>
> >>>>> The release candidate tag in git to be voted upon: release-3.5.5-rc3
> >>>>>
> >>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> >>>>> http://www.apache.org/dist/zookeeper/KEYS <http://www.apache.org/dist/zookeeper/KEYS>
<http://www.apache.org/dist/zookeeper/KEYS <http://www.apache.org/dist/zookeeper/KEYS>>
> >>>>>
> >>>>> Should we release this candidate?
> >>>>>
> >>>>>
> >>> <rat.txt.gz>
>

Mime
View raw message