zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] anmolnar edited a comment on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed
Date Tue, 30 Apr 2019 10:36:03 GMT
anmolnar edited a comment on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when
a transaction failed
URL: https://github.com/apache/zookeeper/pull/839#issuecomment-487903745
 
 
   @TisonKun Interesting topic. After spending some hours looking into the code I think you
might not be able to implement this in a backward compatible-way. Maybe we need a more senior
developer to advise on this, but as far as I can see there's no length information in multi
response, so there's no way to decide whether the path info needs to be extracted from the
`InputArchive` or not.
   
   I've reviewed ZOOKEEPER-107 patch as an example of doing schema change in backward compatible
way and it looks like `LearnerHandler` manually deserialises the `LearnerInfo` packet. It
checks for the size of QuorumPacket and based on that information it can decide what's included
in the packet. Not sure if we can do something similar here. Maybe you're facing a limitation
of Jute and a reason to migrate from it. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message