zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] ericlee123 edited a comment on issue #924: ZOOKEEPER-3371: Port unification for Jetty admin server
Date Mon, 29 Apr 2019 19:34:45 GMT
ericlee123 edited a comment on issue #924: ZOOKEEPER-3371: Port unification for Jetty admin
server
URL: https://github.com/apache/zookeeper/pull/924#issuecomment-487709824
 
 
   > Isn't there a way to force https?
   
   I tried adding that logic to the UnifiedConnectionFactory, but I wasn't able to do it simply.
I concluded that such a feature would probably be a bigger change that would be better off
in a separate PR.
   
   > Why don't you simply open a separate port for https? What's the reward?
   
   The nice thing about port unification is that it makes client migration a lot easier. It
also avoids the hassle of tracking yet another port (one for secure, one for plaintext). While
I do agree there is quite a lot of logic for SSL detection, it is nice and isolated from the
rest of the codebase. Also, port unification for the admin server mirrors the approach taken
for securing quorum ports.
   
   I will update the documentation and fix the build failure for Travis CI.
   
   Thanks for the feedback. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message