zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #925: ZOOKEEPER-3372 Cleanup pom.xml in order to let Maven clients import as few dependencies as possible
Date Sun, 28 Apr 2019 13:42:25 GMT
eolivelli commented on a change in pull request #925: ZOOKEEPER-3372 Cleanup pom.xml in order
to let Maven clients import as few dependencies as possible
URL: https://github.com/apache/zookeeper/pull/925#discussion_r279195392
 
 

 ##########
 File path: zookeeper-assembly/src/main/assembly/bin-package.xml
 ##########
 @@ -29,29 +29,23 @@
     <componentDescriptor>src/main/assembly/components.xml</componentDescriptor>
   </componentDescriptors>
 
-  <moduleSets>
-    <!-- ZooKeeper jars (excluding pom projects) including 3rd party dependencies -->
-    <moduleSet>
-      <useAllReactorProjects>true</useAllReactorProjects>
+  <dependencySets>
+    <dependencySet>
       <includes>
-        <include>org.apache.zookeeper:zookeeper</include>
+        <include>*:*</include>
       </includes>
-
-      <binaries>
-        <outputDirectory>lib</outputDirectory>
-        <unpack>false</unpack>
-        <dependencySets>
-          <dependencySet>
-            <excludes>
-              <exclude>org.apache.zookeeper:zookeeper-recipes</exclude>
-              <exclude>org.apache.zookeeper:zookeeper-client</exclude>
-              <exclude>org.apache.zookeeper:zookeeper-docs</exclude>
-            </excludes>
-          </dependencySet>
-        </dependencySets>
-      </binaries>
-    </moduleSet>
-  </moduleSets>
+      <excludes>
+         <exclude>org.apache.zookeeper:zookeeper-recipes</exclude>
 
 Review comment:
   I can fix that warning.
   I had to change from modueleSet to dependencySets in order to have morw control (in my
experience) over the list of jars to include (and with moduleSet I was not able to include
the 'provided' dependencies).
   
   I can't fix the warning now, if Andor wants to commit this change soon you can pick up
the branch, I think we can just add exclusion or I can do it tonight

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message