zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider
Date Fri, 26 Apr 2019 21:01:30 GMT
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper -
move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-487198257
 
 
   There are failing tests (ObserverMasterTest and CommandsTest.
   I am digging into, but at first glance the problem is that now all of the ServerStats reported
by the MonitorCommand are bound to the same MetricsProvider which is held by a *static reference*
(in ServerMetrics) so it is shared among all of the servers started during the test.
   I am trying to find a smart fix for this situation, otherwise it will be very difficult
to run tests with multiple servers and check the metrics.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message