zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] anmolnar commented on a change in pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed
Date Fri, 26 Apr 2019 15:45:41 GMT
anmolnar commented on a change in pull request #839: ZOOKEEPER-3290: Throw detailed KeeperException
when a transaction failed
URL: https://github.com/apache/zookeeper/pull/839#discussion_r279002359
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/Zab1_0Test.java
 ##########
 @@ -1250,7 +1250,7 @@ public void testInitialAcceptedCurrent() throws Exception {
             long zxid = ZxidUtils.makeZxid(3, 3);
             logFactory.append(new Request(1, 1, ZooDefs.OpCode.error,
                     new TxnHeader(1, 1, zxid, 1, ZooDefs.OpCode.error),
-                    new ErrorTxn(1), zxid));
+                    new ErrorTxn(1, ""), zxid));
 
 Review comment:
   ...and here too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message