zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file
Date Sat, 13 Apr 2019 09:10:03 GMT
eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a simple checkstyle
file
URL: https://github.com/apache/zookeeper/pull/909#discussion_r275110966
 
 

 ##########
 File path: zookeeper-client/zookeeper-client-c/pom.xml
 ##########
 @@ -55,6 +55,8 @@
             <id>test-cppunit</id>
             <phase>test</phase>
             <configuration>
+              <!-- do not run cpp tests if tests are globally skipped -->
+              <skip>${skipTests}</skip> 
 
 Review comment:
   this is for running -Pfull-build on Travis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message