zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] anmolnar commented on a change in pull request #907: ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha
Date Fri, 12 Apr 2019 14:48:07 GMT
anmolnar commented on a change in pull request #907: ZOOKEEPER-3351 - Fix findBugs and rat
check, add filename to sha
URL: https://github.com/apache/zookeeper/pull/907#discussion_r274939800
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/Version.java
 ##########
 @@ -41,6 +42,8 @@ public static String getBuildDate() {
         return BUILD_DATE;
     }
 
+    @SuppressFBWarnings(value = "RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE",
+            justification = "If SNAPSHOT is missing from version number this is redundant")
 
 Review comment:
   Let's say "QUALIFIER" instead of "SNAPSHOT".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message