zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] anmolnar commented on a change in pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor
Date Fri, 12 Apr 2019 11:56:46 GMT
anmolnar commented on a change in pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor
URL: https://github.com/apache/zookeeper/pull/904#discussion_r274872394
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java
 ##########
 @@ -148,6 +146,28 @@ public void testClientAddrFromClientPort()
         assertEquals(quorumPeerConfig.getClientPortAddress(), qs.clientAddr);
     }
 
+    @Test
+    public void testJvmPauseMonitorConfigured()
+            throws IOException, ConfigException {
+        final Long sleepTime = 444L;
+        final Long warnTH = 5555L;
+        final Long infoTH = 555L;
+
+        QuorumPeerConfig quorumPeerConfig = new MockQuorumPeerConfig(1);
 
 Review comment:
   Please don't use the "mocked" version here, it's not needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message