From dev-return-79039-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sat Mar 9 15:51:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C156A18062C for ; Sat, 9 Mar 2019 16:51:05 +0100 (CET) Received: (qmail 80224 invoked by uid 500); 9 Mar 2019 15:51:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 80213 invoked by uid 99); 9 Mar 2019 15:51:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 Mar 2019 15:51:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 4CEC2C21B6 for ; Sat, 9 Mar 2019 15:51:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.5 X-Spam-Level: X-Spam-Status: No, score=-109.5 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Lr9jQzEbOpKX for ; Sat, 9 Mar 2019 15:51:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7C0A85FAC3 for ; Sat, 9 Mar 2019 15:51:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 872ABE031B for ; Sat, 9 Mar 2019 15:51:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3FCB2257F7 for ; Sat, 9 Mar 2019 15:51:00 +0000 (UTC) Date: Sat, 9 Mar 2019 15:51:00 +0000 (UTC) From: "Enrico Olivelli (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3303) ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3303?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16788715#comment-16788715 ]=20 Enrico Olivelli commented on ZOOKEEPER-3303: -------------------------------------------- Can you please reproduce your failure on current master? Our policy is to fix master and then backport I am not and user of perl client Which is the command line to reproduce the issue. It seems to me that it is only a matter of fixing code quality issues > ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fe= dora > -------------------------------------------------------------------------= ---- > > Key: ZOOKEEPER-3303 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3303 > Project: ZooKeeper > Issue Type: Bug > Components: c client, contrib > Affects Versions: 3.4.8, 3.4.12, 3.4.13 > Environment: Fedora 29 in docker > Reporter: Hari Sekhon > Priority: Blocker > > ZooKeeper Perl client zkperl fails to compile on Fedora 29 (compiles ok o= n CentOS 7 though). I cannot build the project to get the zkperl dependenci= es to run on Fedora as it is. This happens on various versions of ZooKeeper= 3.4.x > {code:java} > # perl Makefile.PL --zookeeper-include=3D/usr/local/include --zookeeper-l= ib=3D/usr/local/lib > Generating a Unix-style Makefile > Writing Makefile for Net::ZooKeeper > Writing MYMETA.yml and MYMETA.json > # make > Skip blib/lib/Net/ZooKeeper.pm (unchanged) > Running Mkbootstrap for ZooKeeper () > chmod 644 "ZooKeeper.bs" > "/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- ZooKeeper.bs = blib/arch/auto/Net/ZooKeeper/ZooKeeper.bs 644 > gcc -c -I/usr/local/include -I. -D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe = -Wall -Werror=3Dformat-security -Wp,-D_FORTIFY_SOURCE=3D2 -Wp,-D_GLIBCXX_AS= SERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs= =3D/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=3D/usr/lib/rpm/redhat/red= hat-annobin-cc1 -m64 -mtune=3Dgeneric -fasynchronous-unwind-tables -fstack-= clash-protection -fcf-protection -fwrapv -fno-strict-aliasing -I/usr/local/= include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 -g -DVERSION=3D\"0.3= 6\" -DXS_VERSION=3D\"0.36\" -fPIC "-I/usr/lib64/perl5/CORE" ZooKeeper.c > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper_acl_constant=E2=80=99= : > ZooKeeper.c:784:7: warning: unused variable =E2=80=98RETVAL=E2=80=99 [-Wu= nused-variable] > AV * RETVAL; > ^~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper_CLONE=E2=80=99: > ZooKeeper.c:1089:9: warning: unused variable =E2=80=98package=E2=80=99 [-= Wunused-variable] > char * package =3D (char *)SvPV_nolen(ST(0)) > ^~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper_CLONE_SKIP=E2=80=99: > ZooKeeper.c:1109:9: warning: unused variable =E2=80=98package=E2=80=99 [-= Wunused-variable] > char * package =3D (char *)SvPV_nolen(ST(0)) > ^~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper_TIEHASH=E2=80=99: > ZooKeeper.c:1129:9: warning: unused variable =E2=80=98package=E2=80=99 [-= Wunused-variable] > char * package =3D (char *)SvPV_nolen(ST(0)) > ^~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper_UNTIE=E2=80=99: > ZooKeeper.c:1151:5: warning: unused variable =E2=80=98ref_count=E2=80=99 = [-Wunused-variable] > IV ref_count =3D (IV)SvIV(ST(1)) > ^~~~~~~~~ > ZooKeeper.c:1150:17: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper attr_hash; > ^~~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper_SCALAR=E2=80=99: > ZooKeeper.c:1281:17: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper attr_hash; > ^~~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper_DELETE=E2=80=99: > ZooKeeper.c:1528:7: warning: unused variable =E2=80=98attr_key=E2=80=99 [= -Wunused-variable] > SV * attr_key =3D ST(1) > ^~~~~~~~ > ZooKeeper.c:1527:17: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper attr_hash; > ^~~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper_CLEAR=E2=80=99: > ZooKeeper.c:1561:17: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper attr_hash; > ^~~~~~~~~ > ZooKeeper.xs: In function =E2=80=98XS_Net__ZooKeeper_add_auth=E2=80=99: > ZooKeeper.xs:1206:30: warning: format =E2=80=98%u=E2=80=99 expects argume= nt of type =E2=80=98unsigned int=E2=80=99, but argument 3 has type =E2=80= =98STRLEN=E2=80=99 {aka =E2=80=98long unsigned int=E2=80=99} [-Wformat=3D] > Perl_croak(aTHX_ "invalid certificate length: %u", cert_len)= ; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~ > ZooKeeper.xs: In function =E2=80=98XS_Net__ZooKeeper_create=E2=80=99: > ZooKeeper.xs:1286:30: warning: format =E2=80=98%u=E2=80=99 expects argume= nt of type =E2=80=98unsigned int=E2=80=99, but argument 3 has type =E2=80= =98STRLEN=E2=80=99 {aka =E2=80=98long unsigned int=E2=80=99} [-Wformat=3D] > Perl_croak(aTHX_ "invalid data length: %u", buf_len); > ^~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~ > ZooKeeper.xs:1321:21: error: format not a string literal and no format ar= guments [-Werror=3Dformat-security] > Perl_croak(aTHX_ err); > ^~~~~~~~~~ > ZooKeeper.xs: In function =E2=80=98XS_Net__ZooKeeper_set=E2=80=99: > ZooKeeper.xs:1760:30: warning: format =E2=80=98%u=E2=80=99 expects argume= nt of type =E2=80=98unsigned int=E2=80=99, but argument 3 has type =E2=80= =98STRLEN=E2=80=99 {aka =E2=80=98long unsigned int=E2=80=99} [-Wformat=3D] > Perl_croak(aTHX_ "invalid data length: %u", buf_len); > ^~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~ > ZooKeeper.xs: In function =E2=80=98XS_Net__ZooKeeper_set_acl=E2=80=99: > ZooKeeper.xs:1923:13: error: format not a string literal and no format ar= guments [-Werror=3Dformat-security] > Perl_croak(aTHX_ err); > ^~~~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Stat_CLONE=E2=80=99: > ZooKeeper.c:2871:9: warning: unused variable =E2=80=98package=E2=80=99 [-= Wunused-variable] > char * package =3D (char *)SvPV_nolen(ST(0)) > ^~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Stat_CLONE_SKIP=E2= =80=99: > ZooKeeper.c:2891:9: warning: unused variable =E2=80=98package=E2=80=99 [-= Wunused-variable] > char * package =3D (char *)SvPV_nolen(ST(0)) > ^~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Stat_TIEHASH=E2=80= =99: > ZooKeeper.c:2911:9: warning: unused variable =E2=80=98package=E2=80=99 [-= Wunused-variable] > char * package =3D (char *)SvPV_nolen(ST(0)) > ^~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Stat_UNTIE=E2=80=99: > ZooKeeper.c:2933:5: warning: unused variable =E2=80=98ref_count=E2=80=99 = [-Wunused-variable] > IV ref_count =3D (IV)SvIV(ST(1)) > ^~~~~~~~~ > ZooKeeper.c:2932:23: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper__Stat attr_hash; > ^~~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Stat_SCALAR=E2=80=99= : > ZooKeeper.c:3065:23: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper__Stat attr_hash; > ^~~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Stat_STORE=E2=80=99: > ZooKeeper.c:3167:7: warning: unused variable =E2=80=98attr_val=E2=80=99 [= -Wunused-variable] > SV * attr_val =3D ST(2) > ^~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Stat_DELETE=E2=80=99= : > ZooKeeper.c:3271:7: warning: unused variable =E2=80=98attr_key=E2=80=99 [= -Wunused-variable] > SV * attr_key =3D ST(1) > ^~~~~~~~ > ZooKeeper.c:3270:23: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper__Stat attr_hash; > ^~~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Stat_CLEAR=E2=80=99: > ZooKeeper.c:3304:23: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper__Stat attr_hash; > ^~~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Watch_CLONE=E2=80=99= : > ZooKeeper.c:3405:9: warning: unused variable =E2=80=98package=E2=80=99 [-= Wunused-variable] > char * package =3D (char *)SvPV_nolen(ST(0)) > ^~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Watch_CLONE_SKIP=E2= =80=99: > ZooKeeper.c:3425:9: warning: unused variable =E2=80=98package=E2=80=99 [-= Wunused-variable] > char * package =3D (char *)SvPV_nolen(ST(0)) > ^~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Watch_TIEHASH=E2=80= =99: > ZooKeeper.c:3445:9: warning: unused variable =E2=80=98package=E2=80=99 [-= Wunused-variable] > char * package =3D (char *)SvPV_nolen(ST(0)) > ^~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Watch_UNTIE=E2=80=99= : > ZooKeeper.c:3467:5: warning: unused variable =E2=80=98ref_count=E2=80=99 = [-Wunused-variable] > IV ref_count =3D (IV)SvIV(ST(1)) > ^~~~~~~~~ > ZooKeeper.c:3466:24: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper__Watch attr_hash; > ^~~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Watch_SCALAR=E2=80= =99: > ZooKeeper.c:3599:24: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper__Watch attr_hash; > ^~~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Watch_DELETE=E2=80= =99: > ZooKeeper.c:3803:7: warning: unused variable =E2=80=98attr_key=E2=80=99 [= -Wunused-variable] > SV * attr_key =3D ST(1) > ^~~~~~~~ > ZooKeeper.c:3802:24: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper__Watch attr_hash; > ^~~~~~~~~ > ZooKeeper.c: In function =E2=80=98XS_Net__ZooKeeper__Watch_CLEAR=E2=80=99= : > ZooKeeper.c:3836:24: warning: variable =E2=80=98attr_hash=E2=80=99 set bu= t not used [-Wunused-but-set-variable] > Net__ZooKeeper__Watch attr_hash; > ^~~~~~~~~ > cc1: some warnings being treated as errors > make: *** [Makefile:335: ZooKeeper.o] Error 1 > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)