From dev-return-78915-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Mar 4 21:54:00 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 10821180627 for ; Mon, 4 Mar 2019 22:53:59 +0100 (CET) Received: (qmail 13332 invoked by uid 500); 4 Mar 2019 21:53:59 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 13310 invoked by uid 99); 4 Mar 2019 21:53:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Mar 2019 21:53:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 09C74184A6D for ; Mon, 4 Mar 2019 21:53:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.798 X-Spam-Level: * X-Spam-Status: No, score=1.798 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DC9lf_SYlQJk for ; Mon, 4 Mar 2019 21:53:56 +0000 (UTC) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B72955F239 for ; Mon, 4 Mar 2019 21:53:55 +0000 (UTC) Received: by mail-oi1-f174.google.com with SMTP id i8so5141330oib.10 for ; Mon, 04 Mar 2019 13:53:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=cnYQNvLmLiD4uL1RQMj0eM8bPOWMEMo0nVytoClBiyk=; b=pkyvKZybD+kksAToYBvsqGqHKZz3fVkgUVwIhRxyuCTynsJQrHGVX5k+o1mnS8Crt6 0EFCQwbjclKD4cTY0Dc0J3v+LSz/TO54I43pmvV1OAqY/C7TkJZgsSgb1NbaN4CYKAH+ g6DRgcEa+boTRc3Bs0Jsxk6cMpcM2ckXpmiV1ZNgp8SBY1ya9YPaw+3PT91+o8QBaBie kUSwAQ3cjcJM7fBdzaWMg0TAvp45O4c7iXpu+tCPehIx73jWVrDhj5JEkWrCZPaAfwmF zvrDnaqkXs5QWGASjclp7JUZ01n0V6/0z2hVNX6+2qFDkT6wQkZwjOkjSgHDNxCw9pBF 2MUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=cnYQNvLmLiD4uL1RQMj0eM8bPOWMEMo0nVytoClBiyk=; b=Pb/HqryNL2Hqj574+Zhvq1yHbqYVWSlzFrOHmck3ZldOu1B/zecBXGGVeKdKPqD3o7 7xsGsrT/cKSPElicLTHNkdOIfwJu9IuZbyjrFwrMQBrTpFnQs4ej26Ird5I0qCUARz9v Zh12kAQN2vryyFk5E9KnIu3BrfCbw7QclrXjEFwS6dO+fGV1XrLuEznt2DYAxfC74w43 LTO9ZydRz2Qb/67mkiw21XPe1LwJolfeK8S/SWgIKONLdebzBM04ygQOBhNqAPw9Sx1g DKMNvmtfSjhdqKJfRikxwySs/YnQSJVasYmPdELnCcMon7hOX/T+q+yK57reB0mf1uJA tYHQ== X-Gm-Message-State: APjAAAUy5uwmEVtf9TZDQx02BEfu+72barxqXnYjEI/O69hRm6HeHTsF sdJQ8AojhDYaTmhlyZ8wpTeoUke5819ws5ligBvqhw== X-Google-Smtp-Source: AHgI3IZKV1XIEEhHDFuQEPU662eNM18L/8jKJ645tsVxWODO67KkWS5neMOOTIe9nP3ELN4jjUBOHNciQARncpJw2mU= X-Received: by 2002:aca:40d7:: with SMTP id n206mr12882778oia.105.1551736434860; Mon, 04 Mar 2019 13:53:54 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Brian Nixon Date: Mon, 4 Mar 2019 13:53:43 -0800 Message-ID: Subject: Re: Question on ZK commit/patch policy. To: dev@zookeeper.apache.org Content-Type: multipart/alternative; boundary="000000000000fc294b05834bca84" --000000000000fc294b05834bca84 Content-Type: text/plain; charset="UTF-8" I like having JIRAs for all changes because it allows one to track all the changes to given components through the JIRA web interface and it forces the contributor to spend some time upfront making sure their change is a single coherent unit. For trivial changes like spelling, whitespace, pruning of import, does it make sense to have one super/umbrella ticket with multiple PRs attached? -Brian On Wed, Feb 27, 2019 at 1:04 PM Enrico Olivelli wrote: > I think that having a JIRA makes it simpler to create release notes and > track bugfixes/new features. > Trivial changes, like typos are not worth a JIRA. > > My 2 cents > Enrico > > Il mer 27 feb 2019, 17:57 Patrick Hunt ha scritto: > > > Yea, the commit I just did was a single missing space so no big deal. > > Jordan's link is to curator current policy which seems very similar to > > ours. > > > > I know what current state is. My question though is what do people think? > > Stay with the current mechanism or move to something else? Staying put is > > fine, I just wanted to review given it's been a while (10+ years!) since > we > > last considered this and with github/gitbox and time baselines have > changed > > considerably over that time. > > > > Patrick > > > > > > On Wed, Feb 27, 2019 at 8:44 AM Andor Molnar > > > wrote: > > > > > There were a few typo/language/cosmetic related patches which were so > > small > > > that we've decided it's probably not worth the effort to create a Jira > > for > > > every one of them. > > > Similarly, I haven't created Jiras for issues that were found in > release > > > candidates. > > > > > > Other than this we generally still don't accept patches without Jira > > ticket > > > and properly formatted title / commit message. > > > > > > Andor > > > > > > > > > > > > On Wed, Feb 27, 2019 at 5:38 PM Patrick Hunt wrote: > > > > > > > Historically we've only committed changes that have an associated > JIRA. > > > Now > > > > with the move to gitbox we are seeing increased submissions (PRs) > that > > > > don't include a JIRA - I just committed one and then realized that it > > > > didn't include a JIRA (sorry about that!). Given github and the > recent > > > move > > > > to gitbox significantly streamlines the contribution process I'm > > > wondering > > > > if we should reconsider our process. Any thoughts? Anyone work on > > another > > > > Apache project that does things differently and has pro/con to share? > > > > > > > > Regards, > > > > > > > > Patrick > > > > > > > > > > --000000000000fc294b05834bca84--