From dev-return-79428-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Mar 20 00:15:35 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 15E4F180626 for ; Wed, 20 Mar 2019 01:15:34 +0100 (CET) Received: (qmail 17894 invoked by uid 500); 20 Mar 2019 00:15:34 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 17873 invoked by uid 99); 20 Mar 2019 00:15:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Mar 2019 00:15:34 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] enixon commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server Message-ID: <155304093355.31405.18027585948380016646.gitbox@gitbox.apache.org> Date: Wed, 20 Mar 2019 00:15:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit enixon commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474633770 I like this version. My only comment is to second with @anmolnar 's question about AtomicReference. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services