From dev-return-79380-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Mar 19 04:55:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C37FA18077A for ; Tue, 19 Mar 2019 05:55:01 +0100 (CET) Received: (qmail 67980 invoked by uid 500); 19 Mar 2019 04:55:00 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 67961 invoked by uid 99); 19 Mar 2019 04:54:59 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Mar 2019 04:54:59 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] jhuan31 commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader Message-ID: <155297129939.20297.15676343719281398090.gitbox@gitbox.apache.org> Date: Tue, 19 Mar 2019 04:54:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jhuan31 commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858#discussion_r266731253 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java ########## @@ -101,6 +101,14 @@ public String toString() { private final LearnerSnapshotThrottler learnerSnapshotThrottler; + // log ack latency if zxid is a multiple of ackLoggingFrequency. If <=0, disable logging. + protected static final String ACK_LOGGING_FREQUENCY = "zookeeper.leader.ackLoggingFrequency"; + private static final int ackLoggingFrequency; + static { + ackLoggingFrequency = Integer.getInteger(ACK_LOGGING_FREQUENCY, 1000); Review comment: Can't agree more! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services