From dev-return-79358-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Mar 18 21:18:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id ACD4E180651 for ; Mon, 18 Mar 2019 22:18:05 +0100 (CET) Received: (qmail 20624 invoked by uid 500); 18 Mar 2019 21:18:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 20602 invoked by uid 99); 18 Mar 2019 21:18:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Mar 2019 21:18:04 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor Message-ID: <155294388390.11895.14353815776084740757.gitbox@gitbox.apache.org> Date: Mon, 18 Mar 2019 21:18:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor URL: https://github.com/apache/zookeeper/pull/855#discussion_r266645839 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ########## @@ -231,6 +231,14 @@ public ZooKeeperServer(FileTxnSnapLog txnLogFactory, int tickTime) this(txnLogFactory, tickTime, -1, -1, -1, new ZKDatabase(txnLogFactory)); } + public Deque getOutstandingChanges() { + return outstandingChanges; Review comment: I've changed the unit test so it doesn't need the getter anymore. So this field stays as is. Alos reverted the code to access the field directly (which is not nice) instead of calling the getter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services