From dev-return-79221-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Mar 14 19:41:24 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 03592180630 for ; Thu, 14 Mar 2019 20:41:23 +0100 (CET) Received: (qmail 6143 invoked by uid 500); 14 Mar 2019 19:41:23 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 6123 invoked by uid 99); 14 Mar 2019 19:41:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Mar 2019 19:41:23 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] eolivelli commented on a change in pull request #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush Message-ID: <155259248246.20900.12648693246673411920.gitbox@gitbox.apache.org> Date: Thu, 14 Mar 2019 19:41:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit eolivelli commented on a change in pull request #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush URL: https://github.com/apache/zookeeper/pull/851#discussion_r265735662 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ########## @@ -145,6 +145,10 @@ private ZooKeeperServerShutdownHandler zkShutdownHandler; private volatile int createSessionTrackerServerId = 1; + private static volatile long flushDelay = Long.getLong("zookeeper.flushDelay", 0); Review comment: Can we have these variables as instance variables? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services