From dev-return-79194-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Mar 13 23:23:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2B90718064A for ; Thu, 14 Mar 2019 00:23:54 +0100 (CET) Received: (qmail 88000 invoked by uid 500); 13 Mar 2019 23:23:54 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 87979 invoked by uid 99); 13 Mar 2019 23:23:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Mar 2019 23:23:54 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] enixon commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size Message-ID: <155251943355.11398.12387472316595155501.gitbox@gitbox.apache.org> Date: Wed, 13 Mar 2019 23:23:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit enixon commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#discussion_r265370057 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ########## @@ -873,6 +873,10 @@ public int getGlobalOutstandingLimit() { return limit; } + public static long getSnapSize() { + return Long.getLong("zookeeper.snapSize", 4294967296L); // 4GB by default Review comment: Excellent point! I've extended the documentation to describe the new property. Let's leave it on by default and let the community decide if they want to modify that value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services