From dev-return-79188-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Mar 13 18:24:38 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C8B4A180763 for ; Wed, 13 Mar 2019 19:24:37 +0100 (CET) Received: (qmail 35145 invoked by uid 500); 13 Mar 2019 18:24:36 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 35123 invoked by uid 99); 13 Mar 2019 18:24:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Mar 2019 18:24:36 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] phunt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255 Message-ID: <155250147617.5695.13702219776702865896.gitbox@gitbox.apache.org> Date: Wed, 13 Mar 2019 18:24:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit phunt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255 URL: https://github.com/apache/zookeeper/pull/832#discussion_r265270476 ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ########## @@ -721,6 +721,10 @@ private void setupMyId() throws IOException { throw new IllegalArgumentException("serverid " + myIdString + " is not a number"); } + //myid must be in [0, 255] + if (serverId < 0 || serverId > 255) { Review comment: I believe the recent changes for TTL limit this to 254? @Randgalt can you weigh in here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services