From dev-return-79070-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sun Mar 10 17:19:53 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4013C180672 for ; Sun, 10 Mar 2019 18:19:53 +0100 (CET) Received: (qmail 13498 invoked by uid 500); 10 Mar 2019 17:19:52 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 13475 invoked by uid 99); 10 Mar 2019 17:19:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Mar 2019 17:19:52 +0000 From: GitBox To: dev@zookeeper.apache.org Subject: [GitHub] [zookeeper] phunt commented on a change in pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs Message-ID: <155223839168.28073.18333542878900601784.gitbox@gitbox.apache.org> Date: Sun, 10 Mar 2019 17:19:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit phunt commented on a change in pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs URL: https://github.com/apache/zookeeper/pull/831#discussion_r264049061 ########## File path: zookeeper-client/zookeeper-client-c/src/mt_adaptor.c ########## @@ -502,13 +502,13 @@ int32_t fetch_and_add(volatile int32_t* operand, int incr) } // make sure the static xid is initialized before any threads started -__attribute__((constructor)) int32_t get_xid() Review comment: gotcha, makes sense. And given we are retaining the warning comment on the method itself we should be OK for future generations... Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services