zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fangmin Lv (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (ZOOKEEPER-3291) improve error message when JAVA_HOME is set to the wrong value
Date Fri, 15 Mar 2019 05:36:00 GMT

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Fangmin Lv resolved ZOOKEEPER-3291.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: 3.6.0

Issue resolved by pull request 834
[https://github.com/apache/zookeeper/pull/834]

> improve error message when JAVA_HOME is set to the wrong value
> --------------------------------------------------------------
>
>                 Key: ZOOKEEPER-3291
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3291
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 3.4.12
>         Environment: Windows
>            Reporter: Mogens Heller Grabe
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.6.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is small (Windows-based) developer usability improvement.
> When the {{JAVA_HOME}} environment variable is set, but the value is wrong (so that
{{JAVA_HOME}} + {{/bin/java.exe}} does not point correctly to {{java.exe}}), the startup
script will simply fail with the message
> {{Error: JAVA_HOME is incorrectly set.}}
> which is a bummer. 😞
> With this tiny change, the error message will be much friendlier:
> {{Error: JAVA_HOME is incorrectly set: C:\Program Files\Java\jre1.8.0_201\bin}}
> {{Expected to find java.exe here: C:\Program Files\Java\jre1.8.0_201\bin\bin\java.exe}}
> (in this case showing a situation where one has inadvertently included {{/bin}} in the
{{JAVA_HOME}} environment variable).
> This will also give a nicer error message in situations, where the JRE has been updated,
and the one pointed to by {{JAVA_HOME}} has been uninstalled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message