zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] phunt commented on a change in pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets
Date Thu, 21 Mar 2019 16:57:09 GMT
phunt commented on a change in pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path'
needs a brackets
URL: https://github.com/apache/zookeeper/pull/864#discussion_r267859530
 
 

 ##########
 File path: zookeeper-docs/src/main/resources/markdown/zookeeperStarted.md
 ##########
 @@ -166,7 +166,7 @@ From the shell, type `help` to get a listing of commands that can be
executed fr
         addauth scheme auth
         delete path [version]
         deleteall path
-        setquota -n|-b val path
+        setquota [-n|-b] val path
 
 Review comment:
   I don't believe this is optional, see SetQuotaCommand, in particular "setRequired(true)"
   
   ```
       public SetQuotaCommand() {
           super("setquota", "-n|-b val path");
           
           OptionGroup og1 = new OptionGroup();
           og1.addOption(new Option("b", true, "bytes quota"));
           og1.addOption(new Option("n", true, "num quota"));
           og1.setRequired(true);
           options.addOptionGroup(og1);
      }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message