zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server
Date Tue, 19 Mar 2019 00:37:27 GMT
anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data
Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474153585
 
 
   Thanks @eolivelli . Great stuff.
   
   Unfortunately I kinda lost tracking the conversation in the previous patch, but why are
we doing
   > Make ServerMetrics a class, not an enum.
   
   I liked the enum approach, why do you need to change it?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message