zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor
Date Sun, 17 Mar 2019 10:35:58 GMT
eolivelli commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep
processor
URL: https://github.com/apache/zookeeper/pull/855#discussion_r266233330
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java
 ##########
 @@ -183,10 +186,12 @@ private ChangeRecord getOutstandingChange(String path) {
         }
     }
 
-    private void addChangeRecord(ChangeRecord c) {
-        synchronized (zks.outstandingChanges) {
-            zks.outstandingChanges.add(c);
-            zks.outstandingChangesForPath.put(c.path, c);
+    protected void addChangeRecord(ChangeRecord c) {
+        LOG.info("addChangeRecord called");
 
 Review comment:
   Is this a debug to drop?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message