zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor
Date Sun, 17 Mar 2019 10:35:58 GMT
eolivelli commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep
processor
URL: https://github.com/apache/zookeeper/pull/855#discussion_r266233318
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java
 ##########
 @@ -157,8 +160,8 @@ public void run() {
 
     private ChangeRecord getRecordForPath(String path) throws KeeperException.NoNodeException
{
         ChangeRecord lastChange = null;
-        synchronized (zks.outstandingChanges) {
-            lastChange = zks.outstandingChangesForPath.get(path);
+        synchronized (zks.getOutstandingChanges()) {
 
 Review comment:
   Can you call the getter outside the synchronized block and then. Use the reference to the
returned object?
   It will be clearer that we are accessing the same object

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message