zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] lvfangmin commented on a change in pull request #840: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server
Date Fri, 15 Mar 2019 06:02:24 GMT
lvfangmin commented on a change in pull request #840:  ZOOKEEPER-3143 Pluggable metrics system
for ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/840#discussion_r265855002
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/metrics/MetricsContext.java
 ##########
 @@ -62,9 +62,27 @@
 
     /**
      * Returns a summary.
+     * The returned Summary is expected to track
+     * only simple aggregated values, like min/max/avg.
+     * <p>If you get a Summary with this method you cannot
+     * request the same with {@link #getSummary(java.lang.String) }
      *
      * @param name
      * @return the summary identified by name in this context.
+     * @see #getSummary(java.lang.String)
+     */
+    Summary getBasicSummary(String name);
 
 Review comment:
   Can we merge this into getSummary and add a flag in the parameter to show basic or advanced?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message