zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] enixon commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size
Date Wed, 13 Mar 2019 23:23:53 GMT
enixon commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based
on log size
URL: https://github.com/apache/zookeeper/pull/770#discussion_r265370057
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -873,6 +873,10 @@ public int getGlobalOutstandingLimit() {
         return limit;
     }
 
+    public static long getSnapSize() {
+        return Long.getLong("zookeeper.snapSize", 4294967296L); // 4GB by default
 
 Review comment:
   Excellent point! I've extended the documentation to describe the new property. Let's leave
it on by default and let the community decide if they want to modify that value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message