zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] phunt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255
Date Wed, 13 Mar 2019 18:24:36 GMT
phunt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the
number of myid which must be between 1 and 255
URL: https://github.com/apache/zookeeper/pull/832#discussion_r265270476
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
 ##########
 @@ -721,6 +721,10 @@ private void setupMyId() throws IOException {
             throw new IllegalArgumentException("serverid " + myIdString
                     + " is not a number");
         }
+        //myid must be in [0, 255]
+        if (serverId < 0 || serverId > 255) {
 
 Review comment:
   I believe the recent changes for TTL limit this to 254?
   
   @Randgalt can you weigh in here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message