zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] jhuan31 commented on a change in pull request #849: ZOOKEEPER-3305: Add Quorum Packet metrics
Date Tue, 12 Mar 2019 16:19:54 GMT
jhuan31 commented on a change in pull request #849: ZOOKEEPER-3305: Add Quorum Packet metrics
URL: https://github.com/apache/zookeeper/pull/849#discussion_r264763382
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -649,6 +683,14 @@ public void run() {
         }
     }
 
+    /**
+     * Tests need not send marker packets as they are only needed to
+     * log quorum packet delays
+     */
+    protected boolean shouldSendMarkerPacketForLogging() {
 
 Review comment:
   You have sharp eyes! Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message