zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] maoling commented on issue #688: reduce session revalidation time after zxid roll over
Date Mon, 11 Mar 2019 11:08:43 GMT
maoling commented on issue #688: reduce session revalidation time after zxid roll over
URL: https://github.com/apache/zookeeper/pull/688#issuecomment-471497290
 
 
   @TyqITstudent Thanks for floating up this perfermance improvement issue, I hava some questions
about the solution you had provided.
   
   - > "´╝łEvery half tickTime, followers will send sessions of touchTable to leader to
validate´╝ë."
              
       "Every half tickTime" where do you find this frequency? I found that the sessions which's
going to be revalidated by leader were sent with the ping packet(code: `Follower#processPacket`).
   - if `timeout < currentTime - timeA` (i.e. `currentTime > timeout + timeA`) Does
this means this parts of sessions are all expired,so have less priorty to process at once?
`currentTime > timeout + timeA` is the majority situation? Do I get your idea?
   - for the improvement,IMO,we can add a rate limiter or throttling strategy when the leader
receives too many revalidate requests from the followers,and the leader can process the revalidate
requests in the batch way(code:`Leader#revalidateSession`) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message