zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] jhuan31 commented on a change in pull request #840: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server
Date Sun, 10 Mar 2019 17:35:10 GMT
jhuan31 commented on a change in pull request #840:  ZOOKEEPER-3143 Pluggable metrics system
for ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/840#discussion_r264047120
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatcherCleanerTest.java
 ##########
 @@ -134,8 +136,10 @@ public void testMaxInProcessingDeadWatchers() {
 
     @Test
     public void testDeadWatcherMetrics() {
+        ServerMetrics serverMetrics = new ServerMetrics(new DefaultMetricsProvider());
 
 Review comment:
   In WatchManagerTest, DEFAULT_METRICS_FOR_TESTS is used (and resetAll is indeed called before
each test). Just wondering whether there is any subtle difference between these two testcases
that one creates a new instance and one uses the static instance?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message