zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [zookeeper] eolivelli commented on issue #840: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server
Date Sun, 10 Mar 2019 10:28:38 GMT
eolivelli commented on issue #840:  ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper -
Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/840#issuecomment-471275409
 
 
   @jhuan31 we can't use a global ServerMetrics variable because we are introducing the MetricsProvider
system.
   We want full control over the lifecycle of metrics.
   
   Having static variables makes it unreliable to know when the metrics provider is configured/started
.
   
   Having defaults with NullMetricsProvider ensures that you don't need null checks.
   
   Unfortunately the lifecycle of several components is not very clear, because we have a
lot of constructors used only for tests.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message